netdev - Re: [PATCH net] tcp: fix NULL ref in tail loss probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 05 Dec 2018 16:35:37 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ycheng@...gle.com
Cc:     gregkh@...uxfoundation.org, netdev@...r.kernel.org,
        edumazet@...gle.com, ncardwell@...gle.com, rafael.tinoco@...aro.org
Subject: Re: [PATCH net] tcp: fix NULL ref in tail loss probe

From: Yuchung Cheng <ycheng@...gle.com>
Date: Wed,  5 Dec 2018 14:38:38 -0800

> TCP loss probe timer may fire when the retranmission queue is empty but
> has a non-zero tp->packets_out counter. tcp_send_loss_probe will call
> tcp_rearm_rto which triggers NULL pointer reference by fetching the
> retranmission queue head in its sub-routines.
> 
> Add a more detailed warning to help catch the root cause of the inflight
> accounting inconsistency.
> 
> Reported-by: Rafael Tinoco <rafael.tinoco@...aro.org>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>

Applied, thanks for working to diagnose this so quickly.