netdev - Re: [PATCH][net-next] tun: align write-heavy flow entry members to a cache line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181206.121625.1284474704778994708.davem@davemloft.net>
Date:   Thu, 06 Dec 2018 12:16:25 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lirongqing@...du.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH][net-next] tun: align write-heavy flow entry members to
 a cache line

From: Li RongQing <lirongqing@...du.com>
Date: Thu,  6 Dec 2018 16:08:17 +0800

> tun flow entry 'updated' fields are written when receive
> every packet. Thus if a flow is receiving packets from a
> particular flow entry, it'll cause false-sharing with
> all the other who has looked it up, so move it in its own
> cache line
> 
> and update 'queue_index' and 'update' field only when
> they are changed to reduce the cache false-sharing.
> 
> Signed-off-by: Zhang Yu <zhangyu31@...du.com>
> Signed-off-by: Wang Li <wangli39@...du.com>
> Signed-off-by: Li RongQing <lirongqing@...du.com>

Applied.