netdev - Re: mv88e6060: Turn e6060 driver into e6065 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181206203522.GA26718@amd>
Date:   Thu, 6 Dec 2018 21:35:22 +0100
From:   Pavel Machek <pavel@....cz>
To:     David Miller <davem@...emloft.net>
Cc:     andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        netdev@...r.kernel.org, f.fainelli@...il.com, buytenh@...vell.com,
        buytenh@...tstofly.org, nico@...vell.com
Subject: Re: mv88e6060: Turn e6060 driver into e6065 driver

On Thu 2018-12-06 12:23:33, David Miller wrote:
> From: Pavel Machek <pavel@....cz>
> Date: Thu, 6 Dec 2018 14:03:45 +0100
> 
> > @@ -79,7 +82,7 @@ static enum dsa_tag_protocol mv88e6060_get_tag_protocol(struct dsa_switch *ds,
> >  {
> >    //return DSA_TAG_PROTO_QCA;
> >    //return DSA_TAG_PROTO_TRAILER;
> 
> These C++ style comments are not in any of my tree(s).
> 
> Your patch submission really needs to shape up if you want your patches
> to be considered seriously.

This one should have been "RFD". It has way more serious problems then
this, as changelog tried to explain.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)