netdev - RE: [Intel-wired-lan] [PATCH v3 1/2] i40e: fix VLAN.TCI == 0 RX HW offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A1D32C9EE@ORSMSX104.amr.corp.intel.com>
Date:   Thu, 6 Dec 2018 22:47:17 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
Subject: RE: [Intel-wired-lan] [PATCH v3 1/2] i40e: fix VLAN.TCI == 0 RX HW
 offload

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@...osl.org] On
> Behalf Of Michal Miroslaw
> Sent: Tuesday, December 4, 2018 9:31 AM
> To: netdev@...r.kernel.org; intel-wired-lan@...ts.osuosl.org
> Subject: [Intel-wired-lan] [PATCH v3 1/2] i40e: fix VLAN.TCI == 0 RX HW
> offload
> 
> This fixes two bugs in hardware VLAN offload:
>  1. VLAN.TCI == 0 was being dropped
>  2. there was a race between disabling of VLAN RX feature in hardware
>     and processing RX queue, where packets processed in this window
>     could have their VLAN information dropped
> 
> Fix moves the VLAN handling into i40e_process_skb_fields() to save on
> duplicated code. i40e_receive_skb() becomes trivial and so is removed.
> 
> Signed-off-by: Michał Mirosław <michal.miroslaw@...ndesoftware.pl>
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
> v3:
>  * fix whitespace for checkpatch
> v2:
>  * no changes
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c   | 31 +++++--------------
>  .../ethernet/intel/i40e/i40e_txrx_common.h    |  2 --
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  6 +---
>  3 files changed, 9 insertions(+), 30 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>