netdev - Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181205.204958.1878018442106277817.davem@davemloft.net>
Date:   Wed, 05 Dec 2018 20:49:58 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, pjt@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed,  5 Dec 2018 19:13:38 +0100

 ...
> This may lead to some uglification around the indirect calls. In netconf 2018
> Eric Dumazet described a technique to hide the most relevant part of the needed
> boilerplate with some macro help.
> 
> This series is a [re-]implementation of such idea, exposing the introduced
> helpers in a new header file. They are later leveraged to avoid the indirect
> call overhead in the GRO path, when possible.
> 
> Overall this gives > 10% performance improvement for UDP GRO benchmark and
> smaller but measurable for TCP syn flood.
> 
> The added infra can be used in follow-up patches to cope with retpoline overhead
> in other points of the networking stack (e.g. at the qdisc layer) and possibly
> even in other subsystems.
 ...

I like this a lot and unless I hear some objections I'm going to apply this
series tomorrow.

Thanks for working on this Paolo.