netdev - Re: [PATCH bpf] selftests/bpf: add missing pointer dereference for map stacktrace fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5b32b31-0346-7d26-bc95-235718ab0017@lab.ntt.co.jp>
Date:   Fri, 7 Dec 2018 13:31:43 +0900
From:   Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, ast@...nel.org,
        daniel@...earbox.net
Subject: Re: [PATCH bpf] selftests/bpf: add missing pointer dereference for
 map stacktrace fixup



On 12/7/2018 1:14 PM, Stanislav Fomichev wrote:
> I get a segfault without it, other fixups always do dereference, and
> without dereference I don't understand how it can ever work.
> 
> Fixes: 7c85c448e7d74 ("selftests/bpf: test_verifier, check
> bpf_map_lookup_elem access in bpf prog")
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> ---
>   tools/testing/selftests/bpf/test_verifier.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/test_verifier.c
> index df6f751cc1e8..d23929a1985d 100644
> --- a/tools/testing/selftests/bpf/test_verifier.c
> +++ b/tools/testing/selftests/bpf/test_verifier.c
> @@ -14166,7 +14166,7 @@ static void do_test_fixup(struct bpf_test *test, enum bpf_map_type prog_type,
>   		do {
>   			prog[*fixup_map_stacktrace].imm = map_fds[12];
>   			fixup_map_stacktrace++;
> -		} while (fixup_map_stacktrace);
> +		} while (*fixup_map_stacktrace);
>   	}
>   }

It was my mistake. Thanks for the fix!

-Prashant