netdev - Re: [PATCH] net: dsa: ksz: Add reset GPIO handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ce03cb7-b689-b332-2746-937b290cb840@denx.de>
Date:   Fri, 7 Dec 2018 22:52:06 +0100
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com,
        vivien.didelot@...oirfairelinux.com, Woojung.Huh@...rochip.com,
        UNGLinuxDriver@...rochip.com,
        "David S . Miller" <davem@...emloft.net>,
        Tristram Ha <Tristram.Ha@...rochip.com>
Subject: Re: [PATCH] net: dsa: ksz: Add reset GPIO handling

On 12/07/2018 08:55 PM, Andrew Lunn wrote:
>> +	dev->reset_gpio = -1;
>> +	reset_gpio = of_get_named_gpio_flags(np, "reset-gpios", 0,
>> +					     &reset_gpio_flags);
>> +	if (reset_gpio >= 0) {
>> +		flags = (reset_gpio_flags == OF_GPIO_ACTIVE_LOW) ?
>> +			GPIOF_ACTIVE_LOW : 0;
> 
> Can you use devm_gpiod_get_optional()? It makes this a lot simpler.
> Take a look at mv88e6xxx/chip.c which also uses a GPIO for reset.

Done

> You also need to update the binding documentation for this new
> property.

Will do in a separate patch.

-- 
Best regards,
Marek Vasut