netdev - Re: [PATCH net-next 4/4] net: aquantia: add support of RSS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c9f6e18-f747-471d-c62a-69135b4f43fa@aquantia.com>
Date:   Fri, 7 Dec 2018 11:48:31 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
CC:     "David S . Miller" <davem@...emloft.net>,
        Dmitry Bogdanov <Dmitry.Bogdanov@...antia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 4/4] net: aquantia: add support of RSS
 configuration


>> +	/* Fill out the redirection table */
>> +	if (indir) {
>> +		/* Verify user input. */
>> +		for (i = 0; i < rss_entries; i++)
>> +			if (indir[i] >= cfg->num_rss_queues)
>> +				return -EINVAL;
> 
> nit: you shouldn't have to do this, see ethtool_copy_validate_indir().
> 

Thanks, Jakub, indeed. Will resubmit.

Regards,
  Igor