netdev - Re: [PATCH net-next] ip: silence udp zerocopy smatch false positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181208.122700.548013466747012407.davem@davemloft.net>
Date:   Sat, 08 Dec 2018 12:27:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net-next] ip: silence udp zerocopy smatch false positive

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Sat,  8 Dec 2018 06:22:46 -0500

> From: Willem de Bruijn <willemb@...gle.com>
> 
> extra_uref is used in __ip(6)_append_data only if uarg is set.
> 
> Smatch sees that the variable is passed to sock_zerocopy_put_abort.
> This function accesses it only when uarg is set, but smatch cannot
> infer this.
> 
> Make this dependency explicit.
> 
> Fixes: 52900d22288e ("udp: elide zerocopy operation in hot path")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

I looked and can't figure out a better way to fix this :)

Applied, thanks Willem.