netdev - Re: [PATCH] vhost/vsock: fix reset orphans race with close timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181209092731-mutt-send-email-mst@kernel.org>
Date:   Sun, 9 Dec 2018 09:28:58 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     stefanha@...hat.com, kvm@...r.kernel.org, netdev@...r.kernel.org,
        riemensberger@...ami.net, graham.whaley@...il.com
Subject: Re: [PATCH] vhost/vsock: fix reset orphans race with close timeout

On Sat, Dec 08, 2018 at 09:25:44PM -0800, David Miller wrote:
> From: Stefan Hajnoczi <stefanha@...hat.com>
> Date: Thu,  6 Dec 2018 19:14:34 +0000
> 
> > If a local process has closed a connected socket and hasn't received a
> > RST packet yet, then the socket remains in the table until a timeout
> > expires.
> > 
> > When a vhost_vsock instance is released with the timeout still pending,
> > the socket is never freed because vhost_vsock has already set the
> > SOCK_DONE flag.
> > 
> > Check if the close timer is pending and let it close the socket.  This
> > prevents the race which can leak sockets.
> > 
> > Reported-by: Maximilian Riemensberger <riemensberger@...ami.net>
> > Cc: Graham Whaley <graham.whaley@...il.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> 
> Michael please review, and let me know if you want me to apply this
> directly and queue it up for -stable.


I sent this to Linus already.