netdev - Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 09 Dec 2018 11:54:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        bigeasy@...utronix.de, benquike@...il.com,
        mathias.payer@...elwelt.net
Subject: Re: [PATCH] USB: hso: Fix OOB memory access in
 hso_probe/hso_get_config_data

From: Greg KH <gregkh@...uxfoundation.org>
Date: Sun, 9 Dec 2018 17:32:45 +0100

> +	} else {
>  		port_spec = hso_get_config_data(interface);
> +		if (IS_ERR_VALUE((long)port_spec))
> +			goto exit;

'port_spec' is an 'int', it makes no sense to cast it 3 times all the
way back to 'int' to figure out if it is a negative error value or
not. (--> long --> void * --> int)