netdev - Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9d99e34-a12d-46ce-350d-b794326b08fb@nebelwelt.net>
Date:   Sun, 9 Dec 2018 21:17:58 +0100
From:   Mathias Payer <mathias.payer@...elwelt.net>
To:     David Miller <davem@...emloft.net>
Cc:     gregkh@...uxfoundation.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, bigeasy@...utronix.de,
        benquike@...il.com
Subject: Re: [PATCH] USB: hso: Fix OOB memory access in
 hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in
 hso_probe/hso_get_config_data

> The whole kernel is full of situations where an int is returned and if it's
> negative it's an error.  Why is this location so different?
> 
> Just check < 0 and be done with it.

OK, whatever you prefer.

I've attached the updated patch. (Greg, please add your Signed-off-by).

Best,
Mathias

View attachment "bug3-usb-hso.patch" of type "text/x-patch" (1960 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)