netdev - Re: [PATCH] Fix mm->owner point to a task that does not exists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181209201309-mutt-send-email-mst@kernel.org>
Date:   Sun, 9 Dec 2018 20:36:26 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     gchen.guomin@...il.com
Cc:     guominchen <guominchen@...cent.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Jason Wang <jasowang@...hat.com>,
        netdev@...r.kernel.org, paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH]  Fix mm->owner point to a task that does not exists

On Sun, Dec 09, 2018 at 03:21:17PM +0800, gchen.guomin@...il.com wrote:
> From: guominchen <guominchen@...cent.com>
> 
>   Under normal circumstances,When do_exit exits, mm->owner will
>   be updated, but when the kernel process calls unuse_mm and exits,
>   mm->owner cannot be updated. And will point to a task that has
>   been released.
> 
>   Below is my issue on vhost_net:
>     A, B are two kernel processes(such as vhost_worker),
>     C is a user space process(such as qemu), and all
>     three use the mm of the user process C.
>     Now, because user process C exits abnormally, the owner of this
>     mm becomes A. When A calls unuse_mm and exits, this mm->ower
>     still points to the A that has been released.
>     When B accesses this mm->owner again, A has been released.
> 
>   Process A		Process B
>  vhost_worker()	       vhost_worker()
>   ---------    		---------
>   use_mm()		use_mm()
>    ...
>   unuse_mm()
>      tsk->mm=NULL
>    do_exit()     	page fault
>     exit_mm()	 	access mm->owner
>    can't update owner	kernel Oops
> 
> 			unuse_mm()
> 
> Cc: <linux-mm@...ck.org>
> Cc: <linux-kernel@...r.kernel.org>
> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: <netdev@...r.kernel.org>
> Signed-off-by: guominchen <guominchen@...cent.com>
> ---
>  mm/mmu_context.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/mmu_context.c b/mm/mmu_context.c
> index 3e612ae..185bb23 100644
> --- a/mm/mmu_context.c
> +++ b/mm/mmu_context.c
> @@ -56,7 +56,6 @@ void unuse_mm(struct mm_struct *mm)
>  
>  	task_lock(tsk);
>  	sync_mm_rss(mm);
> -	tsk->mm = NULL;
>  	/* active_mm is still 'mm' */
>  	enter_lazy_tlb(mm, tsk);
>  	task_unlock(tsk);

So that will work for vhost because we never drop
the mm reference before destroying the task.
I wonder whether that's true for other users though.

It would seem cleaner to onvoke some callback so
tasks such as vhost can drop the reference.

And looking at all this code, I don't understand why
is mm->owner safe to change like this:
        mm->owner = NULL;

when users seem to use it under RCU.



> -- 
> 1.8.3.1