netdev - Re: [PATCH mlx5-next 07/10] net/mlx5: E-Switch, Change vhca id valid bool field to bit flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181210161216.GF3459@mellanox.com>
Date:   Mon, 10 Dec 2018 16:12:22 +0000
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
CC:     Leon Romanovsky <leonro@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Eli Britstein <elibr@...lanox.com>
Subject: Re: [PATCH mlx5-next 07/10] net/mlx5: E-Switch, Change vhca id valid
 bool field to bit flag

On Sun, Dec 09, 2018 at 07:04:39PM -0800, Saeed Mahameed wrote:
> From: Eli Britstein <elibr@...lanox.com>
> 
> Change the driver flow destination struct to use bit flags with the vhca
> id valid being the 1st one. Done to avoid bool fields in structs, as
> warned by static checkers, with no functionality change.

This is a thing now? I thought the warning was not to use bool with
bitfields for some reason?

Jason