netdev - Re: [PATCH net-next] tcp: handle EOR and FIN conditions the same in tcp_tso_should

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181210.120935.261036914522485949.davem@davemloft.net>
Date:   Mon, 10 Dec 2018 12:09:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, ncardwell@...gle.com, soheil@...gle.com,
        ycheng@...gle.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: handle EOR and FIN conditions the same
 in tcp_tso_should_defer()

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 10 Dec 2018 06:10:02 -0800

> In commit f9bfe4e6a9d0 ("tcp: lack of available data can also cause
> TSO defer") we moved the test in tcp_tso_should_defer() for packets
> with a FIN flag, and we mentioned that the same would be done
> later for EOR flag.
> 
> Both flags should be handled at the same time, after all other
> heuristics have been considered. They both mean that no more bytes
> can be added to this skb by an application.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.