netdev - RE: [Patch net] tipc: fix a double kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR15MB15139EA40D5B1CD2FC87B6E89AA50@DM5PR15MB1513.namprd15.prod.outlook.com>
Date:   Mon, 10 Dec 2018 21:16:29 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Ying Xue <ying.xue@...driver.com>
Subject: RE: [Patch net] tipc: fix a double kfree_skb()

Acked. 
Thank you for both your quick fixes, Cong.

///jon


> -----Original Message-----
> From: Cong Wang <xiyou.wangcong@...il.com>
> Sent: 10-Dec-18 15:46
> To: netdev@...r.kernel.org
> Cc: Cong Wang <xiyou.wangcong@...il.com>; Ying Xue
> <ying.xue@...driver.com>; Jon Maloy <jon.maloy@...csson.com>
> Subject: [Patch net] tipc: fix a double kfree_skb()
> 
> tipc_udp_xmit() drops the packet on error, there is no need to drop it again.
> 
> Fixes: ef20cd4dd163 ("tipc: introduce UDP replicast")
> Reported-and-tested-by:
> syzbot+eae585ba2cc2752d3704@...kaller.appspotmail.com
> Cc: Ying Xue <ying.xue@...driver.com>
> Cc: Jon Maloy <jon.maloy@...csson.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  net/tipc/udp_media.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index
> 10dc59ce9c82..1b1ba1310ea7 100644
> --- a/net/tipc/udp_media.c
> +++ b/net/tipc/udp_media.c
> @@ -245,10 +245,8 @@ static int tipc_udp_send_msg(struct net *net, struct
> sk_buff *skb,
>  		}
> 
>  		err = tipc_udp_xmit(net, _skb, ub, src, &rcast->addr);
> -		if (err) {
> -			kfree_skb(_skb);
> +		if (err)
>  			goto out;
> -		}
>  	}
>  	err = 0;
>  out:
> --
> 2.19.2