netdev - Re: [PATCH bpf-next 0/3] rename *_info_cnt to nr_*_info in bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <781ffb4a-ed88-2e26-c6b3-66b208fb2104@fb.com>
Date:   Mon, 10 Dec 2018 23:01:47 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Yonghong Song <yhs@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next 0/3] rename *_info_cnt to nr_*_info in
 bpf_prog_info

On 12/10/18 2:14 PM, Yonghong Song wrote:
> Before func_info and line_info are added to the kernel, there are several
> fields in structure bpf_prog_info specifying the "count" of a user buffer, e.g.,
>          __u32 nr_jited_ksyms;
>          __u32 nr_jited_func_lens;
> The naming convention has the prefix "nr_".
> 
> The func_info and line_info support added several fields
>          __u32 func_info_cnt;
>          __u32 line_info_cnt;
>          __u32 jited_line_info_cnt;
> to indicate the "count" of buffers func_info, line_info and jited_line_info.
> The original intention is to keep the field names the same as those in
> structure bpf_attr, so it will be clear that the "count" returned to user
> space will be the same as the one passed to the kernel during prog load.
> 
> Unfortunately, the field names *_info_cnt are not consistent with
> other existing fields in bpf_prog_info.
> This patch set renamed the fields *_info_cnt to nr_*_info
> to keep naming convention consistent.

Applied to bpf-next. Thanks