netdev - Re: [PATCH bpf] selftests/bpf: skip sockmap tests on kernels without support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181209163516.62fd19d4@cakuba.netronome.com>
Date:   Sun, 9 Dec 2018 16:35:16 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, ast@...nel.org,
        daniel@...earbox.net, john.fastabend@...il.com
Subject: Re: [PATCH bpf] selftests/bpf: skip sockmap tests on kernels
 without support

On Thu,  6 Dec 2018 19:39:06 -0800, Stanislav Fomichev wrote:
> Include "autoconf.h" header in the test_maps.c and selectively
> disable test_sockmap if CONFIG_BPF_STREAM_PARSER is not specified
> in the kernel config.
> When building out of tree/without autoconf.h, fall back to 'enabled'.
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

No opinion on the merits, but if we are to skip tests I think its
better to use SKIP result.  IMHO its better for person running the test
to know they are not running all the tests than have them silently
disappear.

If we were to conditionally skip tests should we also tackle the
test_verifier cases which require sockmap?

#274/p prevent map lookup in sockmap Failed to create hash map 'Invalid argument'!
FAIL
Unexpected error message!
	EXP: cannot pass map_type 15 into func bpf_map_lookup_elem
	RES: fd -1 is not pointing to valid bpf_map

fd -1 is not pointing to valid bpf_map
#275/p prevent map lookup in sockhash Failed to create hash map 'Invalid argument'!
FAIL
Unexpected error message!
	EXP: cannot pass map_type 18 into func bpf_map_lookup_elem
	RES: fd -1 is not pointing to valid bpf_map

fd -1 is not pointing to valid bpf_map