netdev - Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181210071834.GC7511@kroah.com>
Date:   Mon, 10 Dec 2018 08:18:34 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mathias Payer <mathias.payer@...elwelt.net>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, bigeasy@...utronix.de,
        benquike@...il.com
Subject: Re: [PATCH] USB: hso: Fix OOB memory access in
 hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in
 hso_probe/hso_get_config_data

On Sun, Dec 09, 2018 at 09:17:58PM +0100, Mathias Payer wrote:
> > The whole kernel is full of situations where an int is returned and if it's
> > negative it's an error.  Why is this location so different?
> > 
> > Just check < 0 and be done with it.
> 
> OK, whatever you prefer.

My fault, I was tired and suggested the other way...

> I've attached the updated patch. (Greg, please add your Signed-off-by).

Patches can't be attached, I'll fix this up and resend, thanks.

greg k-h