netdev - Re: [PATCH bpf-next 2/2] samples/bpf: convert xdpsock to use libbpf for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181210160750.6c81cac9@cakuba.netronome.com>
Date:   Mon, 10 Dec 2018 16:07:50 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Magnus Karlsson <magnus.karlsson@...el.com>
Cc:     bjorn.topel@...el.com, ast@...nel.org, daniel@...earbox.net,
        netdev@...r.kernel.org, bjorn.topel@...il.com,
        qi.z.zhang@...el.com, brouer@...hat.com
Subject: Re: [PATCH bpf-next 2/2] samples/bpf: convert xdpsock to use libbpf
 for AF_XDP access

On Mon, 10 Dec 2018 16:34:45 +0100, Magnus Karlsson wrote:
> diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
> index 57ecadc..ca94cfb 100644
> --- a/samples/bpf/xdpsock_user.c
> +++ b/samples/bpf/xdpsock_user.c
> @@ -44,15 +44,8 @@
>  #define PF_XDP AF_XDP
>  #endif
>  
> -#define NUM_FRAMES 131072
> -#define FRAME_HEADROOM 0
> -#define FRAME_SHIFT 11
> -#define FRAME_SIZE 2048
> -#define NUM_DESCS 1024
> -#define BATCH_SIZE 16
> -
> -#define FQ_NUM_DESCS 1024
> -#define CQ_NUM_DESCS 1024
> +#define NUM_FRAMES (4 * 1024)
> +#define BATCH_SIZE 64

nit: small changes to the defines are not mentioned in the commit msg