netdev - Re: [PATCH v3] qmi_wwan: Added support for Fibocom NL668 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r2enlr4c.fsf@miraculix.mork.no>
Date:   Tue, 11 Dec 2018 21:56:19 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Jörgen Storvist <jorgen.storvist@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v3] qmi_wwan: Added support for Fibocom NL668 series

Jörgen Storvist <jorgen.storvist@...il.com> writes:

> Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. 
> Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@...il.com> 
> ---
>
> Changelog:
> v2: list order to correpond to USB VID/PID values. 
> v3: Fixed Patch formatting.
>
> Thanks Bjørn for the inputs! 
> Hopefully I managed to get it somewhat okay this time. 
>
> drivers/net/usb/qmi_wwan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..dada68f 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x1435, 0xd181, 4)},	/* Wistron NeWeb D18Q1 */
>  	{QMI_FIXED_INTF(0x1435, 0xd181, 5)},	/* Wistron NeWeb D18Q1 */
>  	{QMI_FIXED_INTF(0x1435, 0xd191, 4)},	/* Wistron NeWeb D19Q1 */
> +	{QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)},	/* Fibocom NL668 series */
>  	{QMI_FIXED_INTF(0x16d8, 0x6003, 0)},	/* CMOTech 6003 */
>  	{QMI_FIXED_INTF(0x16d8, 0x6007, 0)},	/* CMOTech CHE-628S */
>  	{QMI_FIXED_INTF(0x16d8, 0x6008, 0)},	/* CMOTech CMU-301 */


Looks good.  Only minor thing is this warning I got from git, due to
your latin1 email:

 Warning: commit message did not conform to UTF-8.
 You may want to amend it after fixing the message, or set the config
 variable i18n.commitencoding to the encoding your project uses.

Don't know if that matters though.  The commit message still looks fine
in utf8, so I guess not.

Acked-by: Bjørn Mork <bjorn@...k.no>