netdev - Re: [Patch net-next] net_sched: fold tcf_block_cb_call() into tc_setup_cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181211134404.0adf3856@cakuba.netronome.com>
Date:   Tue, 11 Dec 2018 13:44:04 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, Oz Shlomo <ozsh@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [Patch net-next] net_sched: fold tcf_block_cb_call() into
 tc_setup_cb_call()

On Tue, 11 Dec 2018 11:15:46 -0800, Cong Wang wrote:
> After commit 69bd48404f25 ("net/sched: Remove egdev mechanism"),
> tc_setup_cb_call() is nearly identical to tcf_block_cb_call(),
> so we can just fold tcf_block_cb_call() into tc_setup_cb_call()
> and remove its unused parameter 'exts'.
> 
> Fixes: 69bd48404f25 ("net/sched: Remove egdev mechanism")
> Cc: Oz Shlomo <ozsh@...lanox.com>
> Cc: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks, I didn't want to nit pick too much on Oz's patch :)

The Fixes tag is superfluous, this is far from a bug, unnecessary noise
for backporters.