netdev - Re: [PATCH V2 mlx5-next 4/9] net/mlx5: Add monitor commands layout and event data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUN+veKna5rAFvJMLXWsS5BKLCBbuBFCX_Hy_Z36T22JA@mail.gmail.com>
Date:   Mon, 10 Dec 2018 16:48:58 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     leonro@...lanox.com,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-rdma@...r.kernel.org, Jason Gunthorpe <jgg@...lanox.com>,
        eyald@...lanox.com
Subject: Re: [PATCH V2 mlx5-next 4/9] net/mlx5: Add monitor commands layout
 and event data

On Mon, Dec 10, 2018 at 1:55 PM Saeed Mahameed <saeedm@...lanox.com> wrote:
> +enum mlx5_monitor_counter_ppcnt {
> +       MLX5_QUERY_MONITOR_PPCNT_IN_RANGE_LENGTH_ERRORS      = 0X0,
> +       MLX5_QUERY_MONITOR_PPCNT_OUT_OF_RANGE_LENGTH_FIELD   = 0X1,
> +       MLX5_QUERY_MONITOR_PPCNT_FRAME_TOO_LONG_ERRORS       = 0X2,
> +       MLX5_QUERY_MONITOR_PPCNT_FRAME_CHECK_SEQUENCE_ERRORS = 0X3,
> +       MLX5_QUERY_MONITOR_PPCNT_ALIGNMENT_ERRORS            = 0X4,
> +       MLX5_QUERY_MONITOR_PPCNT_IF_OUT_DISCARDS             = 0X5,
> +};
> +
> +enum {
> +       MLX5_QUERY_MONITOR_Q_COUNTER_RX_OUT_OF_BUFFER     = 0X4,
> +};

Is there any reason to capitalize these 0X prefixes?

Thanks.