netdev - Re: [PATCH net-next] neighbor: gc_list changes should be protected by table lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181210.174200.87804153842648835.davem@davemloft.net>
Date:   Mon, 10 Dec 2018 17:42:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH net-next] neighbor: gc_list changes should be protected
 by table lock

From: David Ahern <dsahern@...nel.org>
Date: Mon, 10 Dec 2018 13:54:07 -0800

> From: David Ahern <dsahern@...il.com>
> 
> Adding and removing neighbor entries to / from the gc_list need to be
> done while holding the table lock; a couple of places were missed in the
> original patch.
> 
> Move the list_add_tail in neigh_alloc to ___neigh_create where the lock
> is already obtained. Since neighbor entries should rarely be moved
> to/from PERMANENT state, add lock/unlock around the gc_list changes in
> neigh_change_state rather than extending the lock hold around all
> neighbor updates.
> 
> Fixes: 58956317c8de ("neighbor: Improve garbage collection")
> Reported-by: Andrei Vagin <avagin@...il.com>
> Reported-by: syzbot+6cc2fd1d3bdd2e007363@...kaller.appspotmail.com
> Reported-by: syzbot+35e87b87c00f386b041f@...kaller.appspotmail.com
> Reported-by: syzbot+b354d1fb59091ea73c37@...kaller.appspotmail.com
> Reported-by: syzbot+3ddead5619658537909b@...kaller.appspotmail.com
> Reported-by: syzbot+424d47d5c456ce8b2bbe@...kaller.appspotmail.com
> Reported-by: syzbot+e4d42eb35f6a27b0a628@...kaller.appspotmail.com
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied, thanks for fixing this so quickly.