netdev - Re: [PATCH net-next 2/9] net: bridge: Propagate extack to switchdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 14:20:02 +0200
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Petr Machata <petrm@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "ivecera@...hat.com" <ivecera@...hat.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        David Ahern <dsa@...ulusnetworks.com>,
        "bridge@...ts.linux-foundation.org" 
        <bridge@...ts.linux-foundation.org>
Subject: Re: [PATCH net-next 2/9] net: bridge: Propagate extack to switchdev

On 12/12/2018 13:52, Petr Machata wrote:
> ndo_bridge_setlink has been updated in the previous patch to have extack
> available, and changelink RTNL op has had this argument since the time
> extack was added. Propagate both through the bridge driver to eventually
> reach br_switchdev_port_vlan_add(), where it will be used by subsequent
> patches.
> 
> Signed-off-by: Petr Machata <petrm@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  net/bridge/br_if.c        |  2 +-
>  net/bridge/br_netlink.c   | 27 +++++++++++++---------
>  net/bridge/br_private.h   | 22 ++++++++++--------
>  net/bridge/br_switchdev.c |  3 ++-
>  net/bridge/br_vlan.c      | 59 ++++++++++++++++++++++++++---------------------
>  5 files changed, 65 insertions(+), 48 deletions(-)
> 

+CC Roopa & bridge list

Looks good to me.
Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>