netdev - Re: [PATCH 7/7] selftest/bpf: fix E501 line too long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 11:06:12 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alice Ferrazzi <alice.ferrazzi@...il.com>, ast@...nel.org,
        shuah@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/7] selftest/bpf: fix E501 line too long

On Wed, 12 Dec 2018 11:24:02 +0100, Daniel Borkmann wrote:
> > -        raise Exception("Time out waiting for program counts to stabilize want %d/%d, have %d bound, %d loaded" % (
> > +        raise Exception("Time out waiting for program counts to \
> > +stabilize want %d/%d, have %d bound, %d loaded" % (
> >              bound, total, nbound, nprogs))  
> 
> I'll leave the test_offload.py ones up to Jakub, but to me it seems
> this particular change here would actually make the code look worse
> and harder to grep for error messages, so my preference would be to
> at least leave the error messages as-is. Also seems it's not a 'must'
> in pep8 [0].
> 
>   [0] https://www.python.org/dev/peps/pep-0008/#maximum-line-length

Thanks, agreed, this has been run through checkpatch, so the line
lengths should be fine (and we don't want error messages split).