netdev - Re: [net-next 08/14] net/mlx5e: Change parse attr struct to accommodate multiple tunnel infos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 17:04:50 -0800
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Netdev List <netdev@...r.kernel.org>,
        elibr@...lanox.com
Subject: Re: [net-next 08/14] net/mlx5e: Change parse attr struct to
 accommodate multiple tunnel infos

On Tue, Dec 11, 2018 at 4:49 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Tue, Dec 11, 2018 at 3:28 PM Saeed Mahameed <saeedm@...lanox.com> wrote:
> >  struct mlx5e_tc_flow_parse_attr {
> > -       struct ip_tunnel_info tun_info;
> > +       struct ip_tunnel_info tun_info[MLX5_MAX_FLOW_FWD_VPORTS];
> >         struct net_device *filter_dev;
> >         struct mlx5_flow_spec spec;
> >         int num_mod_hdr_actions;
> >         void *mod_hdr_actions;
> > -       int mirred_ifindex;
> > +       int mirred_ifindex[MLX5_MAX_FLOW_FWD_VPORTS];
> >  };
>
> Perhaps 'mirred_ifindexes' (or indices) is more readable here, while you
> are on it...

Hi Cong, I actually prefer array names to reflect single entries:
mirred_ifindex[vport]; is more readable
just like when you give a name to a table column, you don't use the plural form.