netdev - Re: [PATCH bpf-next v2 1/2] selftests/bpf: skip maps sockmap tests on kernels without support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e2aa35a-7704-8b81-68bb-4dace9d57c6e@iogearbox.net>
Date:   Wed, 12 Dec 2018 03:05:49 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, ast@...nel.org, jakub.kicinski@...ronome.com
Subject: Re: [PATCH bpf-next v2 1/2] selftests/bpf: skip maps sockmap tests on
 kernels without support

On 12/10/2018 09:43 PM, Stanislav Fomichev wrote:
> Include "autoconf.h" header in the test_maps.c and selectively
> disable test_sockmap if CONFIG_BPF_STREAM_PARSER is not specified
> in the kernel config.
> When building out of tree/without autoconf.h, fall back to 'enabled'.
> 
> v2 changes:
> * add SKIP indication on the stdout
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>

The kconfig selection for skipping features feels slightly random ;),
but the infrastructure seems useful in general and we might extend
it to other cases in future, thus applied to bpf-next, thanks!