netdev - Re: [PATCH net-next] bnxt: lower log priority of hwrm message to info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 21:46:31 -0800
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jonathan Toppins <jtoppins@...hat.com>
Cc:     Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bnxt: lower log priority of hwrm message to info

On Tue, Dec 11, 2018 at 11:23 AM Jonathan Toppins <jtoppins@...hat.com> wrote:
>
>   bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm
> req_type 0x190 seq id 0x6 error 0xffff
>
> The message above is commonly seen when a newer driver is used on
> hardware with older firmware. The issue is this message means nothing to
> anyone except Broadcom. Reduce the message priority to info to not
> confuse users as this message is really informative in nature.
>
> Signed-off-by: Jonathan Toppins <jtoppins@...hat.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 5d21c14853ac..796cb0b139dc 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -3880,9 +3880,9 @@ static int bnxt_hwrm_do_send_msg(struct bnxt *bp, void *msg, u32 msg_len,
>         *valid = 0;
>         rc = le16_to_cpu(resp->error_code);
>         if (rc && !silent)
> -               netdev_err(bp->dev, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n",
> -                          le16_to_cpu(resp->req_type),
> -                          le16_to_cpu(resp->seq_id), rc);
> +               netdev_info(bp->dev, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n",
> +                           le16_to_cpu(resp->req_type),
> +                           le16_to_cpu(resp->seq_id), rc);
>         return rc;
>  }
>

I prefer to fix it by calling _hwrm_send_message_silent() for that
particular message, which is known to be rejected harmlessly by some
older firmware.  Please let me know if you want to send the patch or
you want me to send the patch.  Thanks.