netdev - RE: [PATCH] VSOCK: bind to random port for VMADDR_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 08:23:22 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Stefan Hajnoczi <stefanha@...hat.com>,
        Jorgen Hansen <jhansen@...are.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Lepton Wu <ytht.net@...il.com>
Subject: RE: [PATCH] VSOCK: bind to random port for VMADDR_PORT_ANY

> From: Stefan Hajnoczi <stefanha@...hat.com>
> Sent: Tuesday, December 11, 2018 8:27 AM
> To: Jorgen Hansen <jhansen@...are.com>; Dexuan Cui
> <decui@...rosoft.com>
> Cc: netdev@...r.kernel.org; Lepton Wu <ytht.net@...il.com>
> Subject: Re: [PATCH] VSOCK: bind to random port for VMADDR_PORT_ANY
> 
> On Mon, Dec 10, 2018 at 11:02:35PM -0800, Lepton Wu wrote:
> > The old code always starts from fixed port for VMADDR_PORT_ANY.
> Sometimes
> > when VMM crashed, there is still orphaned vsock which is waiting for
> > close timer, then it could cause connection time out for new started VM
> > if they are trying to connect to same port with same guest cid since the
> > new packets could hit that orphaned vsock. We could also fix this by doing
> > more in vhost_vsock_reset_orphans, but any way, it should be better to start
> > from a random local port instead of a fixed one.
> >
> > Signed-off-by: Lepton Wu <ytht.net@...il.com>
> > ---
> >  net/vmw_vsock/af_vsock.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Jorgen, Dexuan: Any objection to this?  It also affects the other
> AF_VSOCK transports.

Thanks for letting me notice the patch. :-)

Now I saw Lepton's v2 patch, which looks good to me. 

Thanks,
-- Dexuan