netdev - Re: [PATCH net-next] net/mlx5e: Remove set but not used variable 'upriv'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181212.213935.1380628677390085263.davem@davemloft.net>
Date:   Wed, 12 Dec 2018 21:39:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     yuehaibing@...wei.com, leon@...nel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: Remove set but not used variable
 'upriv'

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Thu, 13 Dec 2018 01:24:06 +0000

> On Wed, 2018-12-12 at 17:10 +0200, Leon Romanovsky wrote:
>> On Wed, Dec 12, 2018 at 08:33:53AM +0000, YueHaibing wrote:
>> > Fixes gcc '-Wunused-but-set-variable' warning:
>> > 
>> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function
>> > 'mlx5e_vport_rep_load':
>> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1490:21: warning:
>> >  variable 'upriv' set but not used [-Wunused-but-set-variable]
>> > 
>> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function
>> > 'mlx5e_vport_rep_unload':
>> > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1557:21: warning:
>> >  variable 'upriv' set but not used [-Wunused-but-set-variable]
>> > 
>> > It not used any more since commit ef381359e3a8 ("net/mlx5e: Replace
>> > egdev with
>> > indirect block notifications"). Also remove unused variable
>> > 'uplink_rpriv'
>> > after this change.
>> > 
>> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> > ---
>> >  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 ----------
>> >  1 file changed, 10 deletions(-)
>> > 
>> 
>> Thanks,
>> Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
> 
> Acked-by: Saeed Mahameed <saeedm@...lanox.com>
> 
> Dave as agreed, you can apply this patch to net-next directly.

Done, thanks.