netdev - Re: [PATCH net-next 0/5] net: prefer listeners bound to an address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3747a774-7d0d-c771-2380-cb560f88c7a1@gmail.com>
Date:   Wed, 12 Dec 2018 22:03:47 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Peter Oskolkov <posk@...gle.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Peter Oskolkov <posk.devel@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 0/5] net: prefer listeners bound to an address



On 12/12/2018 01:15 PM, Peter Oskolkov wrote:
> A relatively common use case is to have several IPs configured
> on a host, and have different listeners for each of them. We would
> like to add a "catch all" listener on addr_any, to match incoming
> connections not served by any of the listeners bound to a specific
> address.
> 
> However, port-only lookups can match addr_any sockets when sockets
> listening on specific addresses are present if so_reuseport flag
> is set. This patchset eliminates lookups into port-only hashtable,
> as lookups by (addr,port) tuple are easily available.
> 
> In a future patchset I plan to explore whether it is possible
> to remove port-only hashtables completely: additional refactoring
> will be required, as some non-lookup code uses the hashtables.
> 
> Peter Oskolkov (5):
>   net: udp: prefer listeners bound to an address
>   net: udp6: prefer listeners bound to an address
>   net: tcp: prefer listeners bound to an address
>   net: tcp6: prefer listeners bound to an address
>   selftests: net: test that listening sockets match on address properly

For the whole series :

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks Peter !