netdev - Re: [PATCH] net: phy: tja11xx: Add TJA11xx PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26001882-7e29-1e73-3259-656772d37ad9@denx.de>
Date:   Thu, 13 Dec 2018 14:27:51 +0100
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH] net: phy: tja11xx: Add TJA11xx PHY driver

On 12/13/2018 09:38 AM, Andrew Lunn wrote:
>> +static int tja11xx_config_aneg(struct phy_device *phydev)
>> +{
>> +	phydev->autoneg = 0;
>> +	phydev->speed = SPEED_100;
>> +	phydev->duplex = DUPLEX_FULL;
>> +	phydev->pause = 0;
>> +	phydev->asym_pause = 0;
>> +
>> +	return 0;
>> +}
> 
> Hi Marek

Hi,

> That is, err, interesting. Are you saying the PHY cannot do auto-neg?

There isn't much to auto-negotiate and some of the bits in the standard
registers behave weirdly.

> Does it happen to be a 100T1 device for automotive?

Yes, that's what the commit message says, why ?

>> +
>> +static int tja11xx_config_init(struct phy_device *phydev)
>> +{
>> +	u32 features = SUPPORTED_TP | SUPPORTED_MII | SUPPORTED_100baseT_Full;
>> +	int ret;
>> +
>> +	ret = tja11xx_enable_reg_write(phydev);
>> +	if (ret)
>> +		return ret;
>> +
>> +	phydev->supported &= features;
>> +	phydev->advertising &= features;
> 
> What tree is this code based on? I doubt it is net-next. Please rebase
> and fix up all the things that then break.

4.19ish . Do you have some other review comments on this ?

-- 
Best regards,
Marek Vasut