netdev - Re: [pull request][net-next 00/14] Mellanox, mlx5e updates 2018-12-11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fd083781864e2a68e61d5acddca5df8cd2d2f73.camel@mellanox.com>
Date:   Thu, 13 Dec 2018 01:32:42 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [pull request][net-next 00/14] Mellanox, mlx5e updates 2018-12-11

On Tue, 2018-12-11 at 15:23 -0800, Saeed Mahameed wrote:
> Hi Dave,
> 
> This series includes three updates to mlx5e driver, 
> - Eswitch remote mirroring support.
> - CQE padding for ethernet CQs on PPC.
> - FW monitor counters support.
> 
> For more information please see tag log bleow.
> 
> Please pull and let me know if there's any problem.
> 

Hi Dave, the series status in patchworks is "Changes Requested"
 
but I already addressed Cong's comments, i agree with one of them but
after double checking I found out that the code in question is going to
be changed anyways in downstream patch, so i decided to keep the code
as is in patch #3.

see my last comment:
https://patchwork.ozlabs.org/patch/1011429/
 

> Thanks,
> Saeed.
> 
> ---
> 
> The following changes since commit
> 0bd72117fba2dd51a65eaa7b480adc0eea9a4409:
> 
>   bpf: fix up uapi helper description and sync bpf header with tools
> (2018-12-11 11:06:43 -0800)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux.git
> tags/mlx5e-updates-2018-12-11
> 
> for you to fetch changes up to
> 5c7e8bbb025726f9cb9b2bc050509a94262426f8:
> 
>   net/mlx5e: Use monitor counters for update stats (2018-12-11
> 14:52:20 -0800)
> 
> ----------------------------------------------------------------
> mlx5e-updates-2018-12-11
> 
> From Eli Britstein,
> Patches 1-10 adds remote mirroring support.
> Patches 1-4 refactor encap related code as pre-steps for using per
> destination encapsulation properties.
> Patches 5-7 use extended destination feature for single/multi
> destination scenarios that have a single encap destination.
> Patches 8-10 enable multiple encap destinations for a TC flow.
> 
> From, Daniel Jurgens,
> Patch 11, Use CQE padding for Ethernet CQs, PPC showed up to a 24%
> improvement in small packet throughput
> 
> From Eyal Davidovich,
> patches 12-14, FW monitor counter support
> FW monitor counters feature came to solve the delayed reporting of
> FW stats in the atomic get_stats64 ndo, since we can't access the
> FW at that stage, this feature will enable immediate FW stats updates
> in the driver via fw events on specific stats updates.
> 
> Patch 12, cleanup to avoid querying a FW counter when it is not
> supported
> Patch 13, Monitor counters FW commands support
> Patch 14, Use monitor counters in ethernet netdevice to update FW
> stats reported in the atomic get_stats64 ndo.
> 
> ----------------------------------------------------------------
> Daniel Jurgens (1):
>       net/mlx5e: Use CQE padding for Ethernet CQs
> 
> Eli Britstein (10):
>       net/mlx5: Consider encapsulation properties when comparing
> destinations
>       net/mlx5: E-Switch, Rename esw attr mirror count field
>       net/mlx5e: Refactor eswitch flow attr for destination specific
> properties
>       net/mlx5e: Move flow attr reformat action bit to per dest flags
>       net/mlx5e: Annul encap action ordering requirement
>       net/mlx5e: Replace the split logic with extended destination
>       net/mlx5e: Support header rewrite actions with remote port
> mirroring
>       net/mlx5e: Change parse attr struct to accommodate multiple
> tunnel infos
>       net/mlx5e: Allow association of a flow to multiple encaps
>       net/mlx5e: Support multiple encapsulations for a TC flow
> 
> Eyal Davidovich (3):
>       net/mlx5e: Avoid query PPCNT register if not supported by the
> device
>       net/mlx5e: Monitor counters commands support
>       net/mlx5e: Use monitor counters for update stats
> 
>  drivers/net/ethernet/mellanox/mlx5/core/Makefile   |   2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en.h       |   3 +
>  .../ethernet/mellanox/mlx5/core/en/monitor_stats.c | 169
> +++++++++++++++++++
>  .../ethernet/mellanox/mlx5/core/en/monitor_stats.h |  12 ++
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c  |  16 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en_stats.c |  12 ++
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c    | 181
> ++++++++++++++-------
>  drivers/net/ethernet/mellanox/mlx5/core/eswitch.h  |  16 +-
>  .../ethernet/mellanox/mlx5/core/eswitch_offloads.c |  44 +++--
>  drivers/net/ethernet/mellanox/mlx5/core/fs_core.c  |   5 +-
>  drivers/net/ethernet/mellanox/mlx5/core/wq.c       |   3 +-
>  drivers/net/ethernet/mellanox/mlx5/core/wq.h       |   7 +-
>  include/linux/mlx5/cq.h                            |  10 +-
>  include/linux/mlx5/mlx5_ifc.h                      |   4 +-
>  14 files changed, 393 insertions(+), 91 deletions(-)
>  create mode 100644
> drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c
>  create mode 100644
> drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.h