netdev - Re: [PATCH] qmi_wwan: Added support for Telit LN940 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877egdjji6.fsf@miraculix.mork.no>
Date:   Thu, 13 Dec 2018 20:48:17 +0100
From:   Bjørn Mork <bjorn@...k.no>
To:     Jörgen Storvist <jorgen.storvist@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] qmi_wwan: Added support for Telit LN940 series

Jörgen Storvist <jorgen.storvist@...il.com> writes:

> Added support for the Telit LN940 series cellular modules QMI interface.
> QMI_QUIRK_SET_DTR quirk requied for Qualcomm MDM9x40 chipset.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@...il.com>
> ---
>
> usb-devices output
> T:  Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 21 Spd=480 MxCh= 0
> D:  Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=1bc7 ProdID=1900 Rev=03.10
> S:  Manufacturer=Telit
> S:  Product=Telit LN940 Mobile Broadband
> S:  SerialNumber=0123456789ABCDEF
> C:  #Ifs= 5 Cfg#= 1 Atr=a0 MxPwr=500mA
> I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> I:  If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I:  If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:  If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>
> qmicli -d /dev/cdc-wdm0 -p --dms-get-manufacturer 
> [/dev/cdc-wdm0] Device manufacturer retrieved:
> 	Manufacturer: 'Telit'
> qmicli -d /dev/cdc-wdm0 -p --dms-get-model 
> [/dev/cdc-wdm0] Device model retrieved:
> 	Model: 'Telit LN940 Mobile Broadband'
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index dada68f..c8872dd 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1230,6 +1230,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x1bc7, 0x1101, 3)},	/* Telit ME910 dual modem */
>  	{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},	/* Telit LE920 */
>  	{QMI_QUIRK_SET_DTR(0x1bc7, 0x1201, 2)},	/* Telit LE920, LE920A4 */
> +	{QMI_QUIRK_SET_DTR(0x1bc7, 0x1900, 1)},	/* Telit LN940 series */
>  	{QMI_FIXED_INTF(0x1c9e, 0x9801, 3)},	/* Telewell TW-3G HSPA+ */
>  	{QMI_FIXED_INTF(0x1c9e, 0x9803, 4)},	/* Telewell TW-3G HSPA+ */
>  	{QMI_FIXED_INTF(0x1c9e, 0x9b01, 3)},	/* XS Stick W100-2 from 4G Systems */


looking good.

Acked-by: Bjørn Mork <bjorn@...k.no>