netdev - Re: [PATCH bpf-next] selftests/bpf: Fix sk lookup usage in test_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fbc6afe-bea8-f477-4b9e-4413af02f244@iogearbox.net>
Date:   Thu, 13 Dec 2018 23:43:08 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Yonghong Song <yhs@...com>, Andrey Ignatov <rdna@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "ast@...nel.org" <ast@...nel.org>,
        "joe@...d.net.nz" <joe@...d.net.nz>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Fix sk lookup usage in
 test_sock_addr

On 12/13/2018 10:50 PM, Yonghong Song wrote:
> On 12/13/18 1:19 PM, Andrey Ignatov wrote:
>> Semantic of netns_id argument of bpf_sk_lookup_tcp and bpf_sk_lookup_udp
>> was changed (fixed) in f71c6143c203. Corresponding changes have to be
>> applied to all call sites in selftests. The patch fixes corresponding
>> call sites in test_sock_addr test: pass BPF_F_CURRENT_NETNS instead of 0
>> in netns_id argument.
>>
>> Fixes: f71c6143c203 ("bpf: Support sk lookup in netns with id 0")
>> Reported-by: Yonghong Song <yhs@...com>
>> Signed-off-by: Andrey Ignatov <rdna@...com>
> Thanks for the fix!
> Tested-by: Yonghong Song <yhs@...com>

Applied, thanks!