netdev - Re: [PATCH mlx5-next 2/6] IB/mlx5: Unify e-switch representors load approach between uplink and VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cb2dd2bf96693e09351cabb2625158281b7e0f4.camel@mellanox.com>
Date:   Thu, 13 Dec 2018 03:41:25 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Jason Gunthorpe <jgg@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Mark Bloch <markb@...lanox.com>
Subject: Re: [PATCH mlx5-next 2/6] IB/mlx5: Unify e-switch representors load
 approach between uplink and VFs

On Thu, 2018-12-13 at 03:37 +0000, Jason Gunthorpe wrote:
> On Wed, Dec 12, 2018 at 07:11:37PM -0800, Saeed Mahameed wrote:
> > From: Mark Bloch <markb@...lanox.com>
> > 
> > When in switchdev mode and the add function is called by the core
> > level driver, make sure we only register the callbacks, but don't
> > create the mlx5 IB device or initialize anything. With this change
> > all the IB devices in switchdev mode are created only once the load
> > callback is invoked by the e-switch core sub-module. This follows
> > the design paradigm under which the all the Eth representors must
> > be loaded before any of IB reprs is loaded.
> > 
> > Signed-off-by: Mark Bloch <markb@...lanox.com>
> > Acked-by: Or Gerlitz <ogerlitz@...lanox.com>
> > Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> > ---
> >  drivers/infiniband/hw/mlx5/ib_rep.c  | 11 ++++++++++-
> >  drivers/infiniband/hw/mlx5/main.c    | 29 +++++++++---------------
> > ----
> >  drivers/infiniband/hw/mlx5/mlx5_ib.h |  1 -
> >  3 files changed, 19 insertions(+), 22 deletions(-)
> 
> Why is this going in the shared branch? This looks like an IB patch??
> 

Some upcoming changes to support uplink representor will demand this
refactoring in the mlx5 IB driver, otherwise we will have a broken rdma
eswitch representors untill the two trees are merged.

> Jason