netdev - Re: linux-next: Signed-off-by missing for commits in the bpf-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181213043339.znj2674c2povyl2n@ast-mbp.dhcp.thefacebook.com>
Date:   Wed, 12 Dec 2018 20:33:41 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     sfr@...b.auug.org.au, daniel@...earbox.net, ast@...nel.org,
        netdev@...r.kernel.org, linux-next@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: linux-next: Signed-off-by missing for commits in the bpf-next
 tree

On Wed, Dec 12, 2018 at 04:45:26PM -0800, David Miller wrote:
> From: Alexei Starovoitov <alexei.starovoitov@...il.com>
> Date: Wed, 12 Dec 2018 15:39:10 -0800
> 
> > But this approach doesn't scale.
> > We do rebase our trees when we need to fixup or drop patches and
> > at any given point a number of commits will be committed by me
> > and another set by Daniel. When we rebase we cannot keep adding
> > our SOBs to the other person SOBs.
> > Then comes the next rebase and we get to the point of
> > double and triple SOBs ?
> 
> If you use "--signoff" in whatever commands do the rebase you will
> get exactly one signoff for yourself and Daniel at maximum.  If it
> is there already, git will not add a duplicate one on top.

If Stephen's scripts can recognize SOB anywhere in the log then
--signoff can theoretically solve it.
Unfortunately it's "Incompatible with the --interactive option"
So we have to do things manually
or fix scripts
or fix git.