netdev - Re: [PATCH v2] VSOCK: bind to random port for VMADDR_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181214.144045.35956342346519381.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 14:40:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ytht.net@...il.com
Cc:     netdev@...r.kernel.org, stefanha@...hat.com, decui@...rosoft.com,
        jhansen@...are.com
Subject: Re: [PATCH v2] VSOCK: bind to random port for VMADDR_PORT_ANY

From: Lepton Wu <ytht.net@...il.com>
Date: Tue, 11 Dec 2018 11:12:55 -0800

> The old code always starts from fixed port for VMADDR_PORT_ANY. Sometimes
> when VMM crashed, there is still orphaned vsock which is waiting for
> close timer, then it could cause connection time out for new started VM
> if they are trying to connect to same port with same guest cid since the
> new packets could hit that orphaned vsock. We could also fix this by doing
> more in vhost_vsock_reset_orphans, but any way, it should be better to start
> from a random local port instead of a fixed one.
> 
> Signed-off-by: Lepton Wu <ytht.net@...il.com>

Applied, thanks.