netdev - Re: [Patch net] tipc: check tsk->group in tipc_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181214.154921.460850073871849109.davem@davemloft.net>
Date:   Fri, 14 Dec 2018 15:49:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, ying.xue@...driver.com,
        jon.maloy@...csson.com
Subject: Re: [Patch net] tipc: check tsk->group in tipc_wait_for_cond()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue, 11 Dec 2018 21:43:51 -0800

> tipc_wait_for_cond() drops socket lock before going to sleep,
> but tsk->group could be freed right after that release_sock().
> So we have to re-check and reload tsk->group after it wakes up.
> 
> After this patch, tipc_wait_for_cond() returns -ERESTARTSYS when
> tsk->group is NULL, instead of continuing with the assumption of
> a non-NULL tsk->group.
> 
> (It looks like 'dsts' should be re-checked and reloaded too, but
> it is a different bug.)
> 
> Similar for tipc_send_group_unicast() and tipc_send_group_anycast().
> 
> Reported-by: syzbot+10a9db47c3a0e13eb31c@...kaller.appspotmail.com
> Fixes: b7d42635517f ("tipc: introduce flow control for group broadcast messages")
> Fixes: ee106d7f942d ("tipc: introduce group anycast messaging")
> Fixes: 27bd9ec027f3 ("tipc: introduce group unicast messaging")
> Cc: Ying Xue <ying.xue@...driver.com>
> Cc: Jon Maloy <jon.maloy@...csson.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks Cong.