netdev - PCI: pcim_iomap_regions() is not managed without pcim_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ef7616dc-2b73-2e65-7819-baac44528e9f@synopsys.com>
Date:   Fri, 14 Dec 2018 11:27:19 +0000
From:   Jose Abreu <jose.abreu@...opsys.com>
To:     <linux-pci@...r.kernel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: PCI: pcim_iomap_regions() is not managed without pcim_enable_device()
 ?

Hi,

pcim_iomap_regions() is suposed to be managed but without a call
to pcim_enable_device() the regions will not be freed upon a
driver removal.

Is this a design choice ?

Currently, I need to use the non-managed pci_enable_device()
because I have custom calls to .suspend() and .resume(), but I
would expect that pcim_iounmap_regions() would not be needed ...

Thanks and Best Regards,
Jose Miguel Abreu