netdev - Re: [PATCH net-next] net/mlx4_en: remove fallback after kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181215.114343.166835915267660754.davem@davemloft.net>
Date:   Sat, 15 Dec 2018 11:43:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, tariqt@...lanox.com
Subject: Re: [PATCH net-next] net/mlx4_en: remove fallback after
 kzalloc_node()

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu, 13 Dec 2018 03:03:37 -0800

> kzalloc_node(..., GFP_KERNEL, node) will attempt to allocate
> memory as close as possible to the node.
> 
> There is no need to fallback to kzalloc() if this has failed.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Tariq Toukan <tariqt@...lanox.com>

Tariq, please take a look and review this patch.

Thank you.