netdev - Re: [net-next, PATCH 2/2] net: socionext: remove mmio reads on Tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181215.131545.1617213294915409370.davem@davemloft.net>
Date:   Sat, 15 Dec 2018 13:15:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ilias.apalodimas@...aro.org
Cc:     netdev@...r.kernel.org, jaswinder.singh@...aro.org,
        ard.biesheuvel@...aro.org, masami.hiramatsu@...aro.org,
        masahisa.kojima@...aro.org
Subject: Re: [net-next, PATCH 2/2] net: socionext: remove mmio reads on Tx

From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
Date: Fri, 14 Dec 2018 10:59:01 +0200

> Currently the driver issues 2 mmio reads to figure out the number of
> transmitted packets and clean them. We can get rid of the expensive
> reads since BIT 31 of the Tx descriptor can be used for that.
> We can also remove the budget counting of Tx completions since all of
> the descriptors are not deliberately processed.
> 
> Performance numbers using pktgen are:
> size  pre-patch(pps)  post-patch(pps)
> 64       362483           427916
> 128      358315           411686
> 256      352725           389683
> 512      215675           216464
> 1024     113812           114442
> 
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>

Applied.