netdev - Re: [PATCH net] net: clear skb->tstamp in forwarding paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 15 Dec 2018 13:27:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, geomatsi@...il.com
Subject: Re: [PATCH net] net: clear skb->tstamp in forwarding paths

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 14 Dec 2018 06:46:49 -0800

> Sergey reported that forwarding was no longer working
> if fq packet scheduler was used.
> 
> This is caused by the recent switch to EDT model, since incoming
> packets might have been timestamped by __net_timestamp()
> 
> __net_timestamp() uses ktime_get_real(), while fq expects packets
> using CLOCK_MONOTONIC base.
> 
> The fix is to clear skb->tstamp in forwarding paths.
> 
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Sergey Matyukevich <geomatsi@...il.com>
> Tested-by: Sergey Matyukevich <geomatsi@...il.com>

Applied and queued up for -stable, thanks Eric.