netdev - Re: [PATCH bpf-next v2 2/8] bpf: btf: fix struct/union/fwd types with kind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42d4f4c5-cf1a-1f52-b9a6-a10db5251859@fb.com>
Date:   Sat, 15 Dec 2018 23:19:39 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Yonghong Song <yhs@...com>, Martin Lau <kafai@...com>
CC:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next v2 2/8] bpf: btf: fix struct/union/fwd types with
 kind_flag

On 12/15/18 3:13 PM, Yonghong Song wrote:
>> may be a "union { __u32 offset; __u32 bitsize_offset; };"......
> The union with two __u32 is great idea. Maybe the
> bitsize_offset becomes "bitfield_size_offset" to reflect
> its real intention?

I don't think union and verbose name will help.
imo it's add confusion.
I prefer to keep it as-is with simple 'offset' name.