netdev - Re: BUG at /net/ipx/af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181214222242.5342453c@xeon-e3>
Date:   Fri, 14 Dec 2018 22:22:42 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     tenys <15667082669@....com>
Cc:     netdev@...r.kernel.org
Subject: Re: BUG at /net/ipx/af_ipx.c

On Sat, 15 Dec 2018 12:14:41 +0800 (CST)
tenys <15667082669@....com> wrote:

> it looks like a pointer stored without holding a reference
> for the source code  in kernel version v4.14.88, and the fuction is : ipxitf_insert_socket
> 
> static void ipxitf_insert_socket(struct ipx_interface *intrfc, struct sock *sk)
> {	ipxitf_hold(intrfc);
> 	spin_lock_bh(&intrfc->if_sklist_lock);
> 	ipx_sk(sk)->intrfc = intrfc;
> 	sk_add_node(sk, &intrfc->if_sklist);
> 	spin_unlock_bh(&intrfc->if_sklist_lock);
> 	ipxitf_put(intrfc);
> }
> 
> it assigned the pointer `intrfc` to `sk->intrfc`,  but didn't hold a reference for this pointer.
> it looks like a bug.....if not ,could you please explain the meaning of it?
> thanks a lot！
> 
> 
> 
> 
> 
> 
>  
> 
> 
> 
>  
IPX ha been removed in later kernels.