netdev - Re: [PATCH] brcmfmac: Fix access point mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0a0b249-eb3e-7284-1a99-1c4fc5683850@broadcom.com>
Date:   Sat, 15 Dec 2018 12:06:56 +0100
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Stefan Wahren <stefan.wahren@...e.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
        Wright Feng <wright.feng@...ress.com>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        Rafał Miłecki <rafal@...ecki.pl>,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, netdev@...r.kernel.org
Subject: Re: [PATCH] brcmfmac: Fix access point mode

On 12/12/2018 8:20 PM, Stefan Wahren wrote:
> Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with
> hostapd (device_ap_sme=1 use_monitor=0):
> 
> brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52
> 
> So add the missing mgmt_stypes for AP mode to fix this.
> 
> Fixes: 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> Suggested-by: Arend van Spriel <arend.vanspriel@...adcom.com>

Thanks for submitting this patch.

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@...e.com>
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 7f0a5ba..05bd818 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6309,6 +6309,16 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
>   		.tx = 0xffff,
>   		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
>   		      BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
> +	},
> +	[NL80211_IFTYPE_AP] = {
> +		.tx = 0xffff,
> +		.rx = BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) |
> +		      BIT(IEEE80211_STYPE_REASSOC_REQ >> 4) |
> +		      BIT(IEEE80211_STYPE_PROBE_REQ >> 4) |
> +		      BIT(IEEE80211_STYPE_DISASSOC >> 4) |
> +		      BIT(IEEE80211_STYPE_AUTH >> 4) |
> +		      BIT(IEEE80211_STYPE_DEAUTH >> 4) |
> +		      BIT(IEEE80211_STYPE_ACTION >> 4)
>   	}
>   };
>   
>