netdev - Re: [PATCH net-next 0/2] net: phy: don't stop state machine in case of MDIO error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181216.104343.2044904609106339192.davem@davemloft.net>
Date:   Sun, 16 Dec 2018 10:43:43 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, fugang.duan@....com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] net: phy: don't stop state machine in
 case of MDIO error

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 16 Dec 2018 09:29:16 +0100

> On 15.12.2018 17:17, Heiner Kallweit wrote:
>> If we detect a MDIO error, it seems to be a little bit too aggressive
>> to stop the state machine and bring down the PHY completely.
>> E.g. when polling and we miss one update, then this has no relevant
>> impact.
>> 
>> Heiner Kallweit (2):
>>   net: phy: don't stop state machine in case of MDIO error
>>   net: fec: remove workaround to restart state machine on MDIO error
>> 
>>  drivers/net/ethernet/freescale/fec.h      |  1 -
>>  drivers/net/ethernet/freescale/fec_main.c | 12 -------
>>  drivers/net/phy/phy.c                     | 42 +++++------------------
>>  include/linux/phy.h                       |  2 +-
>>  4 files changed, 10 insertions(+), 47 deletions(-)
>> 
> David, could you please wait with applying this? I should have marked
> it RFC (did so in patchwork meanwhile), need to discuss it with
> Andrew and Florian.

Ok.

I'd like to kindly ask that you not modify patchwork state even for your
own changes, and let me take care of it.

When the patch state changes behind my back it's confusing and I start
wondering if I made a mistake changing the state of patches in my queue.

Thanks.