netdev - Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1544993841.4766.5.camel@debian.org>
Date:   Sun, 16 Dec 2018 20:57:21 +0000
From:   Luca Boccassi <bluca@...ian.org>
To:     Petr Vorel <pvorel@...e.cz>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        petr.vorel@...il.com
Subject: Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test
 loads them

On Sun, 2018-12-16 at 21:21 +0100, Petr Vorel wrote:
> Hi Luca,
> 
> Reviewed-by: Petr Vorel <pvorel@...e.cz>
> LGTM, but I'd suggest 2 small changes (see bellow).
> 
> > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t
> >  TUNNEL_NAME="tunnel_test_ip"
> 
> I'd put KMODS here:
> KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre"
> 
> The reason is maintenance of this script - maybe one day there will
> be other
> modules needed to be added, take this list as a configuration (which
> is usually
> in shell scripts in the top).
> BTW Maintenance was reason why I didn't like duplicity in modules you
> had in v1.
> 
> > +# unload kernel modules to remove dummy interfaces only if they
> > were not in use beforehand
> > +KMODS_REMOVE=
> 
> As a side effect, this could be lower case (showing it's not a
> configuration
> variable, but just normal variable).

Ok, thanks, done both in v3.

-- 
Kind regards,
Luca Boccassi
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)