netdev - Re: [PATCH 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181216081817.GC18287@lunn.ch>
Date:   Sun, 16 Dec 2018 09:18:17 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc:     Woojung.Huh@...rochip.com, UNGLinuxDriver@...rochip.com,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        driverdev-devel@...uxdriverproject.org, davem@...emloft.net,
        netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch
 bindings managed in i2c mode

On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> 
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
> ---
>  .../devicetree/bindings/net/dsa/ksz.txt       | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> index 0f407fb371ce..9e715358cebb 100644
> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -74,3 +74,53 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
>                                                               };
>                                               };
>                               };
> +
> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> +
> +                             eth0: ethernet@...01000 {
> +                                             fixed-link {
> +                                                             speed = <1000>;
> +                                                             full-duplex;
> +                                             };
> +                             };
> +
> +                             i2c0: i2c@...08000 {
> +                                             ksz9897: ksz9897@0 {

Hi Sergio

You should use a generic name here. Plus the @X needs to be the same as the reg value.
So switch: ksz9897@5f.

   Andrew